Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Replace getMergedAbi by findEventTopicLog #420

Merged
merged 16 commits into from
Jul 21, 2023
Merged

Feature: Replace getMergedAbi by findEventTopicLog #420

merged 16 commits into from
Jul 21, 2023

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Jun 21, 2023 •
edited by heueristik
Loading

Description

Replace getMergedAbi by findEventTopicLog.

Task: OS-532

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@josemarinas josemarinas changed the title Feature: Improve getMerggedAbi function filtering Feature: Remove getMerggedAbi filtering Jun 23, 2023
@heueristik heueristik changed the title Feature: Remove getMerggedAbi filtering Feature: Replace getMergedAbi by findEventTopicLog Jul 18, 2023
mathewmeconry
mathewmeconry suggested changes Jul 20, 2023
View reviewed changes
packages/contracts/test/framework/dao/dao-factory.ts Outdated Show resolved Hide resolved
packages/contracts/test/framework/dao/dao-factory.ts Outdated Show resolved Hide resolved
packages/contracts/utils/event.ts Outdated Show resolved Hide resolved
@heueristik heueristik force-pushed the f/OS-532-add-checks-to-getMergedAbi branch from 0b9889e to a9e40fb Compare July 20, 2023 13:17
Rekard0
Rekard0 previously approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mathewmeconry
mathewmeconry previously approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@mathewmeconry mathewmeconry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment. Otherwise looks good to me

packages/contracts/test/framework/dao/dao-factory.ts Outdated Show resolved Hide resolved
@heueristik heueristik dismissed stale reviews from mathewmeconry and Rekard0 via 8f6b669 July 21, 2023 05:53
@heueristik heueristik requested a review from Rekard0 July 21, 2023 07:00
@heueristik heueristik merged commit 873cf25 into develop Jul 21, 2023
@heueristik heueristik deleted the f/OS-532-add-checks-to-getMergedAbi branch July 21, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

@mathewmeconry mathewmeconry mathewmeconry approved these changes

@heueristik heueristik Awaiting requested review from heueristik

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josemarinas @mathewmeconry @Rekard0 @heueristik