Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS-436 : use OSX npm for versioning #418

Merged
merged 21 commits into from
Jul 4, 2023
Merged

OS-436 : use OSX npm for versioning #418

merged 21 commits into from
Jul 4, 2023

Conversation

Rekard0
Copy link
Contributor

@Rekard0 Rekard0 commented Jun 18, 2023 •
edited
Loading

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task: ID

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@Rekard0 Rekard0 changed the title F/os 436 use osx npm for versioning OS-436 : use OSX npm for versioning Jun 20, 2023
@Rekard0 Rekard0 marked this pull request as ready for review June 20, 2023 13:09
@Rekard0 Rekard0 requested a review from heueristik June 20, 2023 13:10
@Rekard0 Rekard0 requested a review from josemarinas June 21, 2023 13:43
heueristik and others added 2 commits June 22, 2023 10:57
@heueristik
Feature/os 436 review (#421)
feff89a 
* feat: improvements to the import paths

* fix: remove comments

* fix: redundant/outdated imports and typescript hints

* fix: rollupjs warnings

* Revert "fix: rollupjs warnings"

This reverts commit 68dd5ab.
@Rekard0
clean up
ee99f98
heueristik
heueristik previously requested changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the comments I made

Rekard0 and others added 3 commits June 22, 2023 12:40
heueristik
heueristik reviewed Jun 23, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. After the commented code is removed, I can approve the PR

@heueristik heueristik dismissed their stale review June 23, 2023 15:11

Changes were applied except commented code that is still left after a merge

heueristik
heueristik previously approved these changes Jun 23, 2023
View reviewed changes
brickpop
brickpop previously approved these changes Jul 1, 2023
View reviewed changes
packages/contracts/deploy/helpers.ts Show resolved Hide resolved
mathewmeconry
mathewmeconry previously approved these changes Jul 1, 2023
View reviewed changes
Copy link
Contributor

@mathewmeconry mathewmeconry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just some small suggestions that would speed up the tests a tiny bit

packages/contracts/test/plugins/utils/addresslist.ts Outdated Show resolved Hide resolved
packages/contracts/test/plugins/utils/addresslist.ts Outdated Show resolved Hide resolved
packages/contracts/test/plugins/utils/addresslist.ts Outdated Show resolved Hide resolved
@Rekard0 Rekard0 dismissed stale reviews from mathewmeconry and brickpop via 6c33d5d July 3, 2023 08:54
@Rekard0 Rekard0 merged commit 21e064d into develop Jul 4, 2023
@heueristik heueristik deleted the f/OS-436_use-osx-npm-for-versioning branch August 1, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josemarinas josemarinas josemarinas left review comments

@brickpop brickpop brickpop approved these changes

@mathewmeconry mathewmeconry mathewmeconry approved these changes

@heueristik heueristik heueristik left review comments

Assignees
No one assigned
Labels
contracts subgraph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rekard0 @mathewmeconry @brickpop @heueristik @josemarinas