Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAO ERC-165 tests #387

Merged
merged 8 commits into from
May 26, 2023
Merged

DAO ERC-165 tests #387

merged 8 commits into from
May 26, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented May 23, 2023 •
edited by jira bot
Loading

Description

Task: OS-448

Type of change

  • testing

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

brickpop
brickpop previously approved these changes May 25, 2023
View reviewed changes
packages/contracts/test/core/dao/dao.ts Show resolved Hide resolved
@heueristik heueristik requested a review from brickpop May 25, 2023 15:17
@heueristik heueristik merged commit 040cb9a into develop May 26, 2023
@heueristik heueristik deleted the feature/dao-erc165-tests branch May 26, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

@brickpop brickpop brickpop approved these changes

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heueristik @brickpop @Rekard0