Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Update membership definition #373

Merged
merged 5 commits into from
May 18, 2023
Merged

Feature: Update membership definition #373

merged 5 commits into from
May 18, 2023

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented May 12, 2023 •
edited by jira bot
Loading

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task: OS-418

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@josemarinas josemarinas requested a review from Rekard0 May 12, 2023 09:36
heueristik
heueristik reviewed May 15, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

packages/subgraph/src/packages/token/governance-erc20.ts Outdated Show resolved Hide resolved
Rekard0
Rekard0 approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

heueristik
heueristik approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josemarinas josemarinas merged commit 2dc178a into develop May 18, 2023
@josemarinas josemarinas deleted the f/OS-418-update-membership-definition branch May 18, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brickpop brickpop brickpop left review comments

@heueristik heueristik heueristik approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

Assignees
No one assigned
Labels
subgraph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josemarinas @brickpop @Rekard0 @heueristik