Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS-385, [M-02] C4arena: Clarifying NatSpec comment for TokenFactory #362

Merged
merged 1 commit into from
Apr 27, 2023
Merged

OS-385, [M-02] C4arena: Clarifying NatSpec comment for TokenFactory #362

merged 1 commit into from
Apr 27, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Apr 26, 2023 •
edited by jira bot
Loading

Description

Clarified that TokenFactory deploys non-upgradeable MerkleMinter contracts by cloning them to save gas, which was raised in the C4arena audit.

Task: OS-385

Type of change

  • Documentation

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

Rekard0
Rekard0 approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@heueristik heueristik merged commit 2eb7e27 into develop Apr 27, 2023
juliettech13 pushed a commit that referenced this pull request Apr 27, 2023
@heueristik @juliettech13
Added clarifying NatSpec comment (#362)
d20a983
@brickpop brickpop deleted the feature/OS-385-token-factory-nat-spec branch April 28, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

@brickpop brickpop brickpop approved these changes

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heueristik @brickpop @Rekard0