Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-reentrant DAO executor #355

Merged
merged 114 commits into from
May 17, 2023
Merged

Non-reentrant DAO executor #355

merged 114 commits into from
May 17, 2023

Commits on Apr 17, 2023

  1. feat: protect the DAO executor against reentrancy

    @heueristik
    heueristik committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    dd7a0dc View commit details
    Browse the repository at this point in the history

  2. fix: remove console.log

    @heueristik
    heueristik committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    ad2fd40 View commit details
    Browse the repository at this point in the history

  3. fix: prevent storage corruption

    @heueristik
    heueristik committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    616b8bf View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. feat: refactored reentrancy guard into a modifier

    @heueristik
    heueristik committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    e45854c View commit details
    Browse the repository at this point in the history

  2. feat: added tests and preliminary versioning

    @heueristik
    heueristik committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    2ac2262 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. chore: cleaning

    @heueristik
    heueristik committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    9fb0473 View commit details
    Browse the repository at this point in the history

  2. fix: remove empty comment

    @heueristik
    heueristik committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    a025523 View commit details
    Browse the repository at this point in the history

  3. fix: refactor findEventTopicLog function

    @heueristik
    heueristik committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    3fcc083 View commit details
    Browse the repository at this point in the history

  4. fix: moved implementation slot and renamed file

    @heueristik
    heueristik committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    02711cc View commit details
    Browse the repository at this point in the history

  5. fix: remove redundant includes

    @heueristik
    heueristik committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    360079c View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. prepare package

    @Rekard0
    Rekard0 committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    1b14d42 View commit details
    Browse the repository at this point in the history

  2. remember the branch

    @Rekard0
    Rekard0 committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    9d73698 View commit details
    Browse the repository at this point in the history

  3. only artifact src

    @Rekard0
    Rekard0 committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    fe9fe0f View commit details
    Browse the repository at this point in the history

  4. correct the paths

    @Rekard0
    Rekard0 committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    c8f10de View commit details
    Browse the repository at this point in the history

  5. correct root path

    @Rekard0
    Rekard0 committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    c878bf4 View commit details
    Browse the repository at this point in the history

  6. update hashes

    @Rekard0
    Rekard0 committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    f319e0c View commit details
    Browse the repository at this point in the history

  7. add logs

    @Rekard0
    Rekard0 committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    3575258 View commit details
    Browse the repository at this point in the history

  8. only copy typechain

    @Rekard0
    Rekard0 committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    1c6b6f8 View commit details
    Browse the repository at this point in the history

  9. generate typechain

    @Rekard0
    Rekard0 committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    9f961cc View commit details
    Browse the repository at this point in the history

  10. setup rollup

    @Rekard0
    Rekard0 committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    e8d6590 View commit details
    Browse the repository at this point in the history

  11. update npm packages

    @Rekard0
    Rekard0 committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    930b436 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'develop' into feature/OS-358-nonreentrant-executor

    @heueristik
    heueristik authored Apr 25, 2023
    Configuration menu
    Copy the full SHA
    049ecc6 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. update rollup index

    @Rekard0
    Rekard0 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    5db940f View commit details
    Browse the repository at this point in the history

  2. add esm cjs

    @Rekard0
    Rekard0 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    4dc131e View commit details
    Browse the repository at this point in the history

  3. add readme

    @Rekard0
    Rekard0 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    6005f06 View commit details
    Browse the repository at this point in the history

  4. remove gitIgnore

    @Rekard0
    Rekard0 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    748b382 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Merge branch 'f/OS-380_npm_package_versions' into feature/OS-358-nonr… 

    …eentrant-executor
    @heueristik
    heueristik committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    f78ad2c View commit details
    Browse the repository at this point in the history

  2. update typechain

    @Rekard0
    Rekard0 committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    f9858c7 View commit details
    Browse the repository at this point in the history

  3. update typescript

    @Rekard0
    Rekard0 committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    1653ca1 View commit details
    Browse the repository at this point in the history

  4. convert script to typescript

    @Rekard0
    Rekard0 committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    03ad311 View commit details
    Browse the repository at this point in the history

  5. change commit hash json

    @Rekard0
    Rekard0 committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    5dd35fe View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. rename types to typechain

    @Rekard0
    Rekard0 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    252b165 View commit details
    Browse the repository at this point in the history

  2. add test

    @Rekard0
    Rekard0 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    ab50a5e View commit details
    Browse the repository at this point in the history

  3. add json to rollup and export types

    @Rekard0
    Rekard0 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    0ad3a4f View commit details
    Browse the repository at this point in the history

  4. update usage test

    @Rekard0
    Rekard0 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    b9230a7 View commit details
    Browse the repository at this point in the history

  5. generate index.ts dynamically

    @Rekard0
    Rekard0 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    30c9593 View commit details
    Browse the repository at this point in the history

  6. update readme

    @Rekard0
    Rekard0 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    50e094c View commit details
    Browse the repository at this point in the history

  7. add empty line

    @Rekard0
    Rekard0 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    744f4f7 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/f/OS-380_npm_package_versions' i… 

    …nto feature/OS-358-nonreentrant-executor
    @heueristik
    heueristik committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    1832124 View commit details
    Browse the repository at this point in the history

  9. update commit hashes

    @heueristik
    heueristik committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    ece3a1f View commit details
    Browse the repository at this point in the history

  10. fix index.ts

    @Rekard0
    Rekard0 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    62f5bdb View commit details
    Browse the repository at this point in the history

  11. chore: update test

    @heueristik
    heueristik committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    559d154 View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'origin/f/OS-380_npm_package_versions' i… 

    …nto feature/OS-358-nonreentrant-executor
    @heueristik
    heueristik committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    d2e5456 View commit details
    Browse the repository at this point in the history

  13. fix: removed redundant imports

    @heueristik
    heueristik committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    cd35fe0 View commit details
    Browse the repository at this point in the history

  14. chore: remove legacy version files of DAO

    @heueristik
    heueristik committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    57f755c View commit details
    Browse the repository at this point in the history

  15. fix: adapt contracts-version tests

    @heueristik
    heueristik committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    8fb39df View commit details
    Browse the repository at this point in the history

  16. fix: remove version in title as contracts will get a constant

    @heueristik
    heueristik committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    c409409 View commit details
    Browse the repository at this point in the history

  17. fix: compile legacy contracts for regression testing

    @heueristik
    heueristik committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    403436c View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Revert "fix: compile legacy contracts for regression testing " 

    This reverts commit 403436c.
    @heueristik
    heueristik committed May 2, 2023
    Configuration menu
    Copy the full SHA
    1043deb View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into feature/OS-358-non… 

    …reentrant-executor
    @heueristik
    heueristik committed May 2, 2023
    Configuration menu
    Copy the full SHA
    757bc4c View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/develop' into feature/OS-358-non… 

    …reentrant-executor
    @heueristik
    heueristik committed May 2, 2023
    Configuration menu
    Copy the full SHA
    1b224a2 View commit details
    Browse the repository at this point in the history

  4. revert versioning changes

    @heueristik
    heueristik committed May 2, 2023
    Configuration menu
    Copy the full SHA
    c900797 View commit details
    Browse the repository at this point in the history

  5. adapt tests

    @heueristik
    heueristik committed May 2, 2023
    Configuration menu
    Copy the full SHA
    9629728 View commit details
    Browse the repository at this point in the history

  6. test with creating symbolic link

    @Rekard0
    Rekard0 committed May 2, 2023
    Configuration menu
    Copy the full SHA
    6261b85 View commit details
    Browse the repository at this point in the history

  7. correct path

    @Rekard0
    Rekard0 committed May 2, 2023
    Configuration menu
    Copy the full SHA
    b2df3f0 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Revert "chore: remove legacy version files of DAO" 

    This reverts commit 57f755c.
    @heueristik
    heueristik committed May 5, 2023
    Configuration menu
    Copy the full SHA
    abfa6af View commit details
    Browse the repository at this point in the history

  2. add legacy versions

    @heueristik
    heueristik committed May 5, 2023
    Configuration menu
    Copy the full SHA
    3e25be2 View commit details
    Browse the repository at this point in the history

  3. fix: renaming of the versions

    @heueristik
    heueristik committed May 5, 2023
    Configuration menu
    Copy the full SHA
    aaff5bd View commit details
    Browse the repository at this point in the history

  4. chore: remove old CI task

    @heueristik
    heueristik committed May 5, 2023
    Configuration menu
    Copy the full SHA
    1ce07f3 View commit details
    Browse the repository at this point in the history

  5. fix: version numbers

    @heueristik
    heueristik committed May 5, 2023
    Configuration menu
    Copy the full SHA
    857a9db View commit details
    Browse the repository at this point in the history

  6. fix: imports

    @heueristik
    heueristik committed May 5, 2023
    Configuration menu
    Copy the full SHA
    9d129f4 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. doc: clarified the origin of the implementation slot

    @heueristik
    heueristik committed May 8, 2023
    Configuration menu
    Copy the full SHA
    f437dbc View commit details
    Browse the repository at this point in the history

  2. fix: versioning

    @heueristik
    heueristik committed May 8, 2023
    Configuration menu
    Copy the full SHA
    168b55b View commit details
    Browse the repository at this point in the history

  3. fix: move files

    @heueristik
    heueristik committed May 8, 2023
    Configuration menu
    Copy the full SHA
    dbe2134 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Jør∂¡ <[email protected]>
    @heueristik @brickpop
    heueristik and brickpop authored May 8, 2023
    Configuration menu
    Copy the full SHA
    5e209e3 View commit details
    Browse the repository at this point in the history

  5. chore: formatting

    @heueristik
    heueristik committed May 8, 2023
    Configuration menu
    Copy the full SHA
    6cbc32e View commit details
    Browse the repository at this point in the history

  6. chore: remove NatSpec version number from osx files

    @heueristik
    heueristik committed May 8, 2023
    Configuration menu
    Copy the full SHA
    1b86fd0 View commit details
    Browse the repository at this point in the history

  7. feat: added more tests

    @heueristik
    heueristik committed May 8, 2023
    Configuration menu
    Copy the full SHA
    9b6a514 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/develop' into feature/OS-358-non… 

    …reentrant-executor
    @heueristik
    heueristik committed May 8, 2023
    Configuration menu
    Copy the full SHA
    ebc96ac View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Applied review suggestion 

    Co-authored-by: Rekard0 <[email protected]>
    @heueristik @Rekard0
    heueristik and Rekard0 authored May 10, 2023
    Configuration menu
    Copy the full SHA
    c9c04f8 View commit details
    Browse the repository at this point in the history

  2. feat: added test checking that execution is still possible after the … 

    …upgrade
    @heueristik
    heueristik committed May 10, 2023
    Configuration menu
    Copy the full SHA
    706de67 View commit details
    Browse the repository at this point in the history

  3. Improved comments

    @heueristik
    heueristik committed May 10, 2023
    Configuration menu
    Copy the full SHA
    9c80df2 View commit details
    Browse the repository at this point in the history

  4. feat: initialize _rentrancyStatus

    @heueristik
    heueristik committed May 10, 2023
    Configuration menu
    Copy the full SHA
    0cabf6b View commit details
    Browse the repository at this point in the history

  5. doc: clarify comments

    @heueristik
    heueristik committed May 10, 2023
    Configuration menu
    Copy the full SHA
    9599e38 View commit details
    Browse the repository at this point in the history

  6. fix: change version number

    @heueristik
    heueristik committed May 10, 2023
    Configuration menu
    Copy the full SHA
    0dee336 View commit details
    Browse the repository at this point in the history

  7. fix: use upgradeToAndCall and correct versions

    @heueristik
    heueristik committed May 10, 2023
    Configuration menu
    Copy the full SHA
    4e9e628 View commit details
    Browse the repository at this point in the history

  8. feat: added initializeUpgradeFrom function and tests

    @heueristik
    heueristik committed May 10, 2023
    Configuration menu
    Copy the full SHA
    6c814d2 View commit details
    Browse the repository at this point in the history

  9. feat: improved function and added more tests

    @heueristik
    heueristik committed May 10, 2023
    Configuration menu
    Copy the full SHA
    f8ca50c View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Merge remote-tracking branch 'origin/develop' into feature/OS-358-non… 

    …reentrant-executor
    @heueristik
    heueristik committed May 11, 2023
    Configuration menu
    Copy the full SHA
    4ea9840 View commit details
    Browse the repository at this point in the history

  2. WIP

    @heueristik
    heueristik committed May 11, 2023
    Configuration menu
    Copy the full SHA
    f8876fd View commit details
    Browse the repository at this point in the history

  3. fix: tests

    @heueristik
    heueristik committed May 11, 2023
    Configuration menu
    Copy the full SHA
    4c2573e View commit details
    Browse the repository at this point in the history

  4. fix: finalize tests

    @heueristik
    heueristik committed May 11, 2023
    Configuration menu
    Copy the full SHA
    ad8fc66 View commit details
    Browse the repository at this point in the history

  5. fix typechain and add a script

    @Rekard0
    Rekard0 committed May 11, 2023
    Configuration menu
    Copy the full SHA
    ca9a176 View commit details
    Browse the repository at this point in the history

  6. fix: typo

    @heueristik
    heueristik committed May 11, 2023
    Configuration menu
    Copy the full SHA
    f689e6c View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. feat: improve initializeUpgradeFrom

    @heueristik
    heueristik committed May 12, 2023
    Configuration menu
    Copy the full SHA
    9303b42 View commit details
    Browse the repository at this point in the history

  2. feat: added _initData parameter

    @heueristik
    heueristik committed May 12, 2023
    Configuration menu
    Copy the full SHA
    cf3b2c1 View commit details
    Browse the repository at this point in the history

  3. feat: added test

    @heueristik
    heueristik committed May 12, 2023
    Configuration menu
    Copy the full SHA
    9cd9e65 View commit details
    Browse the repository at this point in the history

  4. fix: wrong version number

    @heueristik
    heueristik committed May 12, 2023
    Configuration menu
    Copy the full SHA
    452c958 View commit details
    Browse the repository at this point in the history

  5. WIP

    @Rekard0
    Rekard0 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c865dcb View commit details
    Browse the repository at this point in the history

  6. fix remaining tests

    @Rekard0 @heueristik
    Rekard0 authored and heueristik committed May 12, 2023
    Configuration menu
    Copy the full SHA
    758bceb View commit details
    Browse the repository at this point in the history

  7. fix subgraph

    @Rekard0 @heueristik
    Rekard0 authored and heueristik committed May 12, 2023
    Configuration menu
    Copy the full SHA
    fec63aa View commit details
    Browse the repository at this point in the history

  8. add ref depth

    @Rekard0 @heueristik
    Rekard0 authored and heueristik committed May 12, 2023
    Configuration menu
    Copy the full SHA
    559a756 View commit details
    Browse the repository at this point in the history

  9. fix: replacing getContractFactory and getContractAt by typechain fact… 

    …ory calls and added missing awaits
    @heueristik
    heueristik committed May 12, 2023
    Configuration menu
    Copy the full SHA
    df4a9e3 View commit details
    Browse the repository at this point in the history

  10. fix: test timings

    @heueristik
    heueristik committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c1088ef View commit details
    Browse the repository at this point in the history

  11. Merge branch 'fix/fix-typechain-and-contracts-tests' into feature/OS-… 

    …358-nonreentrant-executor
    @heueristik
    heueristik committed May 12, 2023
    Configuration menu
    Copy the full SHA
    728cb80 View commit details
    Browse the repository at this point in the history

  12. fix: re-introduced yarn postinstall

    @heueristik
    heueristik committed May 12, 2023
    Configuration menu
    Copy the full SHA
    099018a View commit details
    Browse the repository at this point in the history

  13. fix: remove redundant includes

    @heueristik
    heueristik committed May 12, 2023
    Configuration menu
    Copy the full SHA
    1a15563 View commit details
    Browse the repository at this point in the history

  14. fix: adapt upgrade tests

    @heueristik
    heueristik committed May 12, 2023
    Configuration menu
    Copy the full SHA
    ba71d52 View commit details
    Browse the repository at this point in the history

  15. feat: optimize if statements

    @heueristik
    heueristik committed May 12, 2023
    Configuration menu
    Copy the full SHA
    51c831c View commit details
    Browse the repository at this point in the history

  16. fix: tests

    @heueristik
    heueristik committed May 12, 2023
    Configuration menu
    Copy the full SHA
    1ab55d6 View commit details
    Browse the repository at this point in the history

  17. feat: rename initializeUpgradeFrom to initializeFrom

    @heueristik
    heueristik committed May 12, 2023
    Configuration menu
    Copy the full SHA
    58a9250 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. fix: correct test description

    @heueristik
    heueristik committed May 15, 2023
    Configuration menu
    Copy the full SHA
    b71193f View commit details
    Browse the repository at this point in the history

  2. fix: removed duplicate file

    @heueristik
    heueristik committed May 15, 2023
    Configuration menu
    Copy the full SHA
    054bca1 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Merge remote-tracking branch 'origin/develop' into feature/OS-358-non… 

    …reentrant-executor
    @heueristik
    heueristik committed May 16, 2023
    Configuration menu
    Copy the full SHA
    263bc1b View commit details
    Browse the repository at this point in the history

  2. fix: merge conflicts

    @heueristik
    heueristik committed May 16, 2023
    Configuration menu
    Copy the full SHA
    0e1128a View commit details
    Browse the repository at this point in the history

  3. fix: re-order changelog entries

    @heueristik
    heueristik committed May 16, 2023
    Configuration menu
    Copy the full SHA
    3c64f8e View commit details
    Browse the repository at this point in the history

  4. fix: remove wrong/redundant import originating from merge

    @heueristik
    heueristik committed May 16, 2023
    Configuration menu
    Copy the full SHA
    d08e1ee View commit details
    Browse the repository at this point in the history

  5. feat: improve upgrade version checks

    @heueristik
    heueristik committed May 16, 2023
    Configuration menu
    Copy the full SHA
    cc571dc View commit details
    Browse the repository at this point in the history

  6. fix: remove redundant ROOT_PERMISSION grant call

    @heueristik
    heueristik committed May 16, 2023
    Configuration menu
    Copy the full SHA
    649732b View commit details
    Browse the repository at this point in the history

  7. feat: added more checks to the upgrade tests

    @heueristik
    heueristik committed May 16, 2023
    Configuration menu
    Copy the full SHA
    c275b62 View commit details
    Browse the repository at this point in the history

  8. feat: more explicit variable naming

    @heueristik
    heueristik committed May 16, 2023
    Configuration menu
    Copy the full SHA
    a97a9ba View commit details
    Browse the repository at this point in the history

  9. fix: reworked initializeFrom logic

    @heueristik
    heueristik committed May 16, 2023
    Configuration menu
    Copy the full SHA
    7c3e22c View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. fix: refactored test according to the logic change

    @heueristik
    heueristik committed May 17, 2023
    Configuration menu
    Copy the full SHA
    e77bdfe View commit details
    Browse the repository at this point in the history

  2. feat: added NatSpec and code comments mentioning the version of added… 

    … storage
    @heueristik
    heueristik committed May 17, 2023
    Configuration menu
    Copy the full SHA
    114afb4 View commit details
    Browse the repository at this point in the history