Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hardhat typescript typing #347

Merged
merged 2 commits into from
Mar 30, 2023
Merged

fix: hardhat typescript typing #347

merged 2 commits into from
Mar 30, 2023

Conversation

mathewmeconry
Copy link
Contributor

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task: ID

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

heueristik
heueristik reviewed Mar 29, 2023
View reviewed changes
packages/contracts/deploy/40_finalize-managing-dao/30_install-multisig-on-managing-dao.ts
@@ -55,29 +57,37 @@ const func: DeployFunction = async function (hre: EHRE) {

// Install multisig build 2
const multisigRepoAddress = hre.aragonPluginRepos['multisig'];
const versionTag = [1, 2];
const pluginSetupRef = [versionTag, multisigRepoAddress];
const versionTag = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can adapt the
export type VersionTag = [number, number]; accordingly in packages/contracts/test/test-utils/psp/types.ts and use it here as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not. packages/contracts/test/test-utils/psp/types.ts is used by tests and is not shared with the deployment scripts

heueristik
heueristik approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Rekard0
Rekard0 approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mathewmeconry mathewmeconry merged commit d5d589e into develop Mar 30, 2023
@mathewmeconry mathewmeconry deleted the fix/hardhat_typing branch March 30, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heueristik heueristik heueristik approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathewmeconry @Rekard0 @heueristik