Fix/deployment script #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rekard0
reviewed
Mar 13, 2023
novaknole
reviewed
Mar 13, 2023
packages/contracts/utils/ens.ts
Outdated
| await ens.setSubnodeRecord( | ||
|
|
||
| // skipping if it is already set | ||
| const resolved = await ens.resolver( |
There was a problem hiding this comment.
I don't get this check ! The above if (resolved === resolver.address) { is a great fix, but this one, I couldn't imagine when this would be worth it.
There was a problem hiding this comment.
This one is necessary because the loop fails if we use a subdomain for one of the ENS configurations. e.g. plugins.dao.eth.
While registering plugins.dao.eth it would try to register dao.eth which already exists and fail
packages/contracts/utils/ens.ts
Outdated
| console.log(`Registering subdomain ${domains[i]}`); | ||
|
|
||
| const resolved = await ens.resolver(ensDomainHash(domains[i])); | ||
| if (resolved === resolver.address) { |
There was a problem hiding this comment.
could you call this resolver ? resolved seems like something was resolved.
There was a problem hiding this comment.
I had to change it to resolvedResolver because resolver is used by the Resolver deployment earlier in the script
Rekard0
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and be sure you follow the contributions rules we do provide here
Task: ID
Type of change
Checklist:
CHANGELOG.mdfile in the root folder.