-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exec results #316
Merged
Merged
exec results #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rekard0
reviewed
Mar 6, 2023
Rekard0
reviewed
Mar 6, 2023
mathewmeconry
suggested changes
Mar 6, 2023
mathewmeconry
approved these changes
Mar 6, 2023
Rekard0
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before arriving to this solution, I tried to have
getProposal
function instead ofupdateProposalWithFailureMap
.getProposal
would return the proposal, anddao.ts
would update and save it which is much better, but I struggled:TokenVotingProposal
in the return type and usedchangetype<TokenVotingProposal>(MultisigProposal.load(...)
, but this didn't work as doingsave
on it failed because ofvotingMode
. Mainly, it thoughtthe type was
TokenVotingProposal
even though underlying thing was MultisigProposal.Task: ID
Type of change
Checklist:
CHANGELOG.md
file in the root folder.