Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exec results #316

Merged
merged 8 commits into from
Mar 6, 2023
Merged

exec results #316

merged 8 commits into from
Mar 6, 2023

Conversation

novaknole
Copy link
Contributor

@novaknole novaknole commented Mar 1, 2023

Description

Before arriving to this solution, I tried to have getProposal function instead of updateProposalWithFailureMap. getProposal would return the proposal, and dao.ts would update and save it which is much better, but I struggled:

  1. The function can't have multiple return types.
  2. So, I mentioned TokenVotingProposal in the return type and used changetype<TokenVotingProposal>(MultisigProposal.load(...), but this didn't work as doing save on it failed because of votingMode. Mainly, it thought
    the type was TokenVotingProposal even though underlying thing was MultisigProposal.

Task: ID

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

packages/subgraph/tests/dao/dao.test.ts Outdated Show resolved Hide resolved
packages/subgraph/tests/dao/dao.test.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@novaknole novaknole merged commit 7c363eb into develop Mar 6, 2023
@novaknole novaknole deleted the f/APP-1710-execresults branch March 6, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants