Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-1896 : Remove duplicated code #307

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

Rekard0
Copy link
Contributor

@Rekard0 Rekard0 commented Feb 28, 2023

Description

Task: APP-1896

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@Rekard0 Rekard0 marked this pull request as ready for review February 28, 2023 13:17
@Rekard0 Rekard0 merged commit 6de66c6 into develop Feb 28, 2023
@novaknole novaknole deleted the f/APP1896_ManagingDAO-test-followup branch February 28, 2023 16:03
juliettech13 pushed a commit that referenced this pull request Feb 28, 2023
* remove duplicated code

* clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants