Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing npm package name #300

Merged
merged 4 commits into from
Feb 28, 2023
Merged

Fixing npm package name #300

merged 4 commits into from
Feb 28, 2023

Conversation

juliettech13
Copy link
Contributor

@juliettech13 juliettech13 commented Feb 27, 2023 •
edited by heueristik
Loading

Description

The current plugin development docs still had the old package name @aragon/core-contracts so devs are getting errors when installing.

Just updated the name to @aragon/osx-contracts.

Task: ID

Type of change

  • Documentation update

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • [n/a] I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • [n/a] My changes generate no new warnings.
  • [n/a] Any dependent changes have been merged and published in downstream modules.
  • [n/a] I ran all tests with success and extended them if necessary.
  • [n/a] I have updated the CHANGELOG.md file in the root folder.
  • [n/a] I have tested my code on the test network.

novaknole
novaknole previously approved these changes Feb 27, 2023
View reviewed changes
brickpop
brickpop previously approved these changes Feb 28, 2023
View reviewed changes
novaknole
novaknole previously approved these changes Feb 28, 2023
View reviewed changes
heueristik
heueristik previously approved these changes Feb 28, 2023
View reviewed changes
@novaknole novaknole self-requested a review February 28, 2023 17:00
novaknole
novaknole previously approved these changes Feb 28, 2023
View reviewed changes
brickpop
brickpop previously approved these changes Feb 28, 2023
View reviewed changes
@brickpop brickpop merged commit 3fbfe7c into develop Feb 28, 2023
@brickpop brickpop deleted the docs-fix branch February 28, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brickpop brickpop brickpop approved these changes

@novaknole novaknole novaknole left review comments

@heueristik heueristik heueristik left review comments

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juliettech13 @brickpop @heueristik @novaknole