Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(APP-3393): Update handling of proposal statuses #267

Merged
merged 10 commits into from
Aug 7, 2024

Conversation

cgero-eth
Copy link
Contributor

@cgero-eth cgero-eth commented Aug 6, 2024

Description

  • Align proposal-status type to proposal-voting-status
  • Make proposal-status strings customisable
  • Export proposalStatusToTagVariant and proposalStatusToVotingStatus utiltities

Task: APP-3393

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth requested a review from a team August 6, 2024 09:08
@cgero-eth cgero-eth changed the title WIP: feat(APP-3393): Update handling of proposal statuses feat(APP-3393): Update handling of proposal statuses Aug 6, 2024
@cgero-eth cgero-eth marked this pull request as ready for review August 6, 2024 09:08
@cgero-eth cgero-eth force-pushed the APP-3393-proposal-status branch 2 times, most recently from b010e8a to 3070d80 Compare August 7, 2024 13:23
@cgero-eth cgero-eth merged commit dbd3e9c into main Aug 7, 2024
4 checks passed
@cgero-eth cgero-eth deleted the APP-3393-proposal-status branch August 7, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant