Updates from Court Dashboard #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpierre
approved these changes
May 15, 2020
Comment on lines
-135
to
-145
| // Makes “gu” a CSS unit in a string, e.g. | ||
| // cssgu`10px 2gu 4gu` | ||
| export function cssgu(strings, ...substitutions) { | ||
| return strings | ||
| .map((str, i) => str + (substitutions[i] || '')) | ||
| .join('') | ||
| .replace(/([0-9]+(?:\.[0-9]+)?)gu/g, (match, value) => { | ||
| value = parseFloat(value) | ||
| return isNaN(value) ? match : `${value * GU}px` | ||
| }) | ||
| } |
There was a problem hiding this comment.
is that something that you used before having the grid unit?
There was a problem hiding this comment.
Yes, this was just before the grid unit was introduced (we released the activity panel late April, and began introducing the GU in mid May).
Evalir
approved these changes
May 18, 2020
| export function validateEmail(email) { | ||
| // eslint-disable-next-line no-useless-escape | ||
| var re = /^(([^<>()\[\]\\.,;:\s@"]+(\.[^<>()\[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/ | ||
| return re.test(String(email).toLowerCase()) | ||
| return /^.+\@.+\..+$/.test(email) |
rperez89
approved these changes
May 19, 2020
| <IconCheck | ||
| css={` | ||
| opacity: 0; | ||
| opacity: ${inputEmail.trim() ? '1' : '0'}; |
There was a problem hiding this comment.
@bpierre hand was around here :)
Comment on lines
-135
to
-145
| // Makes “gu” a CSS unit in a string, e.g. | ||
| // cssgu`10px 2gu 4gu` | ||
| export function cssgu(strings, ...substitutions) { | ||
| return strings | ||
| .map((str, i) => str + (substitutions[i] || '')) | ||
| .join('') | ||
| .replace(/([0-9]+(?:\.[0-9]+)?)gu/g, (match, value) => { | ||
| value = parseFloat(value) | ||
| return isNaN(value) ? match : `${value * GU}px` | ||
| }) | ||
| } |
There was a problem hiding this comment.
is that something that you used before having the grid unit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some of #1425 (will repurpose that issue with the single remaining item):
And a few other small items:
transformAddresses()