Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAI is not visible in Finance app after update #734

Closed
john-light opened this issue Apr 17, 2019 · 1 comment · Fixed by aragon/aragon-apps#813
Closed

DAI is not visible in Finance app after update #734

john-light opened this issue Apr 17, 2019 · 1 comment · Fixed by aragon/aragon-apps#813
Labels
bug

Comments

@john-light
Copy link
Contributor

Describe the bug
I just upgraded the Finance app of my mainnet organization and the DAI that is in my Vault is not showing up in the Finance app, even though it still appears in the Vault on a block explorer.

Mainnet or testnet?
Mainnet

Organization
https://mainnet.aragon.org/#/oncommunity.aragonid.eth/0x68db69930aefb0277384865ae92c2cd1acc87145

To Reproduce
Steps to reproduce the behavior:

  1. Deposit DAI into a non-upgraded pre-2.0.0 Finance app
  2. See that the DAI shows up in the Finance app
  3. Upgrade the Finance app to ≥2.0.0
  4. See that the DAI no longer shows up in the Finance app

Expected behavior
I expect the DAI to still be there

Additional context
https://forum.aragon.org/t/vault-doesnt-display-previously-deposited-erc20-dai-after-0-7-upgrade/845
@john-light john-light added the bug label Apr 17, 2019
@Ro5s
Copy link

Ro5s commented Apr 17, 2019

If I can add to this issue:

DAI deposits do not seem to function in Finance app:
Screen Shot 2019-04-17 at 5 45 13 PM

@sohkai sohkai mentioned this issue Apr 17, 2019
Merged
sohkai added a commit to aragon/aragon-apps that referenced this issue Apr 18, 2019
@sohkai
Finance: fix token fallbacks and error handling (#813)
f207a7e 
Fixes aragon/client#734.

With aragon/aragon.js#277 we now get the actual errors back from the RPC when a call goes wrong (e.g. naive `token.symbol()` on DAI) and we need to handle these explicitly.

This PR converts a lot of the token fallback-related bits into simpler Promise-based code and adds explicit handlers for their error cases.
nickhabets added a commit to nickhabets/aragon that referenced this issue Dec 29, 2020
@nickhabets
Finance: fix token fallbacks and error handling (#813)
7767d36 
Fixes aragon/client#734.

With aragon/aragon.js#277 we now get the actual errors back from the RPC when a call goes wrong (e.g. naive `token.symbol()` on DAI) and we need to handle these explicitly.

This PR converts a lot of the token fallback-related bits into simpler Promise-based code and adds explicit handlers for their error cases.
nickhabets pushed a commit to nickhabets/aragon that referenced this issue Dec 29, 2020
@chongliuzz
Finance: fix token fallbacks and error handling (#813)
c23ec7e 
Fixes aragon/client#734.

With aragon/aragon.js#277 we now get the actual errors back from the RPC when a call goes wrong (e.g. naive `token.symbol()` on DAI) and we need to handle these explicitly.

This PR converts a lot of the token fallback-related bits into simpler Promise-based code and adds explicit handlers for their error cases.
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this issue Dec 9, 2021
@sohkai
Finance: fix token fallbacks and error handling (aragon#813)
dbd3609 
Fixes aragon/client#734.

With aragon/aragon.js#277 we now get the actual errors back from the RPC when a call goes wrong (e.g. naive `token.symbol()` on DAI) and we need to handle these explicitly.

This PR converts a lot of the token fallback-related bits into simpler Promise-based code and adds explicit handlers for their error cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Finance: fix token fallbacks and error handling aragon/aragon-apps
2 participants
@john-light @Ro5s