Use Aragon Connect in dao apps command #1731
Conversation
| * @param {number} Ethereum network id | ||
| */ | ||
| const supportsAragonConnect = (networkId) => { | ||
| return networkId === 1 || networkId === 4 |
There was a problem hiding this comment.
Thinking aloud here: the only reason we would want to continue using aragon.js going into the future is for local development environments (e.g. with buidler), because we wouldn't want to force them to run a graph node locally?
This is a compelling reason for us to eventually build that ethereum connector that we can fallback to if a subgraph is not available / does not contain this org (for whatever reason).
There was a problem hiding this comment.
Yep we can likely remove aragon.js once we stop supporting the local devchain in aragonCLI.
There was a problem hiding this comment.
because we wouldn't want to force them to run a graph node locally
@sohkai you are right it is a good reason. On the other hand, we realize working on a couple of Aragon apps subgraphs that it was esier to a developer using The Graph playground infrastructure directly and just have a staging subgraph that using the graph node locally. I think the main downside of this approach is relying heavily on The Graph infrastructure, but we were able to go a long way with it so far.
There was a problem hiding this comment.
Right, the problem with this (for the buidler environment), is that we most likely don't want the user to run their own subgraph infrastructure for their local chain.
🦅 Pull Request Description
🚨 Test instructions
dao apps <DAO address> --env aragon:rinkeby