Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Payroll): include exchange rate used in SendPayment event #830

Merged
merged 2 commits into from
Apr 30, 2019
Merged

feat(Payroll): include exchange rate used in SendPayment event #830

merged 2 commits into from
Apr 30, 2019

Conversation

sohkai
Copy link
Contributor

@sohkai sohkai commented Apr 29, 2019

No description provided.

@sohkai sohkai requested review from izqui and facuspagnuolo April 29, 2019 06:40
@coveralls
Copy link

coveralls commented Apr 29, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 97.015% when pulling 1b59642 on payroll-emit-exchange-rate into 327abd6 on master.

facuspagnuolo
facuspagnuolo approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@facuspagnuolo facuspagnuolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

future-apps/payroll/test/contracts/Payroll_rates.test.js Outdated Show resolved Hide resolved
@sohkai sohkai merged commit 1f34d07 into master Apr 30, 2019
@sohkai sohkai deleted the payroll-emit-exchange-rate branch April 30, 2019 07:23
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
@sohkai
feat(Payroll): include exchange rate used in SendPayment event (arago…
b7b1034 
…n#830)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facuspagnuolo facuspagnuolo facuspagnuolo approved these changes

@izqui izqui izqui approved these changes

Assignees
No one assigned
Labels
component: contract
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sohkai @coveralls @izqui @facuspagnuolo