Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ganache-cli.sh on Ubuntu #826

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Fix ganache-cli.sh on Ubuntu #826

merged 1 commit into from
Apr 26, 2019

Conversation

kernelwhisperer
Copy link
Contributor

I was getting:

./node_modules/@aragon/test-helpers/ganache-cli.sh: 4: set: Illegal option -o pipefail

I supposed is not a portable option.

I was getting:

```
./node_modules/@aragon/test-helpers/ganache-cli.sh: 4: set: Illegal option -o pipefail
```

Is it supposed to work with it?
Copy link
Contributor

@facuspagnuolo facuspagnuolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.015% when pulling de6ad5e on fix-ganache-cli-script into 01d80a0 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.015% when pulling de6ad5e on fix-ganache-cli-script into 01d80a0 on master.

@sohkai sohkai merged commit 2f76b6c into master Apr 26, 2019
@sohkai sohkai deleted the fix-ganache-cli-script branch April 26, 2019 21:11
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants