Fix voting displayed percent #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
reviewed
Apr 26, 2019
AquiGorka
force-pushed
the
fix/voting-displayed-percent
branch
from
1324ec8 to
1e53dda
Compare
25 tasks
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
* VotingCard: update informative to question * Math utils: refactor scale values set to use bn * Add jest and babel-jest deps for tests * babelrc: add env tests presets * Add math utils tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: fixes aragon/client#742
The error came from this line: the check was not
breaking because(0.55 * 100 * 100) % 1 = 9.094947017729282e-13(even though(0.55 * (100 * 100)) % 1 = 0).Applied the function that is being used in the survey app and added local tests for voting.
As discussed with @bpierre we need to add a
shared/commonlibrary for all the apps.