feat(Payroll): small SLOAD optimizations to _transferTokensAmount() #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for (uint256 i = 0; i < allowedTokensArray.length; i++) { | ||
| address token = allowedTokensArray[i]; | ||
| if (employee.allocation[token] != uint256(0)) { | ||
| uint128 exchangeRate = _getExchangeRate(token); |
There was a problem hiding this comment.
I think dropping this line was not intentionally actually.
There was a problem hiding this comment.
The CI failed due to a compilation error since exchangeRate it's not declared.
There was a problem hiding this comment.
😅 Yes... messed up the merge conflict. Fixed in 9a602f2.
2 similar comments
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
…ragon#822) * feat(Payroll): small SLOAD optimizations to _transferTokensAmount * fix: put back accidentally deleted line from merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should avoid a few unnecessary
SLOADs that result to the same state.