Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finance: date filters remove default selection #819

Merged
merged 8 commits into from
Apr 23, 2019
Merged

Finance: date filters remove default selection #819

merged 8 commits into from
Apr 23, 2019

Conversation

AquiGorka
Copy link
Contributor

These changes:

  • Placeholder for dates: --/--/----
  • When no range is selected today's date is used as placeholder for endDate
  • When startDate is selected but no endDate, then endDate uses the placeholder
  • Date range filter is applied when the user clicks outside of the date range picker instead of when clicking on dates as before
  • Modified today's border to main color
  • Uses monospaced font so that placeholder uses same char width as actual dates and uses ch units to define container's size

Refs: #809 and #767 (comment)

@luisivan luisivan mentioned this pull request Apr 23, 2019
Closed
25 tasks
sohkai
sohkai approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When startDate is selected but no endDate, then endDate uses the placeholder

I think this might get potentially confusing, but let's see how it is with users 👍

@AquiGorka
Copy link
Contributor Author

I think this might get potentially confusing, but let's see how it is with users

@sohkai hmm, yeah, but if it is not done this way then the input appears to have 2 dates selected (start and end) but the period filter is not really being applied.

Let's see how it plays out and I can always come back and iterate on it.

@AquiGorka AquiGorka merged commit 6e0830b into master Apr 23, 2019
@AquiGorka AquiGorka deleted the feature/date-filter-no-default-selection branch April 23, 2019 12:14
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
@AquiGorka
Finance: date filters remove default selection (aragon#819)
13f3221 
* TransferFilters: remove duplicate margin rules

* DatePicker: update today border color

* DateRangePicker: update to allow null values on dates

* Transfers: refactor to no default date selection

* DateRangeInput: fix font family declaration

Co-Authored-By: AquiGorka <[email protected]>

* Transfers: recover non-breaking space

* DateRangeInput: improve placeholder logic and add input placeholder for screen readers

* DateRangeInput: improve on placeholder for accesibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpierre bpierre bpierre approved these changes

@sohkai sohkai sohkai approved these changes

@dizzypaty dizzypaty Awaiting requested review from dizzypaty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AquiGorka @bpierre @sohkai