Voting: fix bug with votes not loading initially #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2color
commented
Apr 17, 2019
| @@ -26,6 +32,8 @@ function appStateReducer(state) { | |||
| tokenDecimals: tokenDecimalsNum, | |||
| }, | |||
|
|
|||
| connectedAccountVotes: connectedAccountVotes || {}, | |||
There was a problem hiding this comment.
This is to ensure there's an object in
aragon-apps/apps/voting/app/src/vote-hooks.js
Lines 29 to 32 in 4afc2ad
sohkai
reviewed
Apr 17, 2019
| @@ -222,7 +224,7 @@ async function startVote(state, { creator, metadata, voteId }) { | |||
| * * | |||
| ***********************/ | |||
|
|
|||
| async function getAccountVotes({ connectedAccount, votes }) { | |||
| async function getAccountVotes({ connectedAccount, votes = [] }) { | |||
There was a problem hiding this comment.
Can we leave a comment for why we need to default this?
sohkai
approved these changes
Apr 17, 2019
A comment in the first place would have prevented that :) |
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
* Voting: fix bug with votes not loading initially * Add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.