Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apps: Tests enhancements #788

Merged
merged 2 commits into from
Apr 18, 2019
Merged

Apps: Tests enhancements #788

merged 2 commits into from
Apr 18, 2019

Conversation

facuspagnuolo
Copy link
Contributor

@facuspagnuolo facuspagnuolo commented Apr 12, 2019 •
edited
Loading

This PR carries some enhancements related to test files:

  • Use new assertRevert promisified interface
  • Remove unused imports and constants
  • Declare magically assigned variables
  • Improve injected accounts usage

@facuspagnuolo facuspagnuolo requested a review from sohkai April 12, 2019 19:07
@aragon aragon deleted a comment from coveralls Apr 13, 2019
@facuspagnuolo facuspagnuolo force-pushed the time_helpers_mock branch 3 times, most recently from 6292397 to e74e51d Compare April 16, 2019 23:36
@facuspagnuolo facuspagnuolo changed the base branch from time_helpers_mock to master April 17, 2019 14:23
sohkai
sohkai approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Just merged with master to double check we haven't messed anything up in the last day. Feel free to merge once it's completed!

Made #816 to track adding revert string assertions to the other apps, which we can do later.

@sohkai sohkai merged commit 65a998f into master Apr 18, 2019
@sohkai sohkai deleted the tests_enhancements branch April 18, 2019 15:05
MickdeGraaf pushed a commit to MickdeGraaf/aragon-apps that referenced this pull request Jan 28, 2020
@facuspagnuolo @sohkai
Apps: Tests enhancements (aragon#788)
f17e4b4
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
@facuspagnuolo @sohkai
Apps: Tests enhancements (aragon#788)
001e08f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohkai sohkai sohkai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@facuspagnuolo @sohkai