Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update App Center copy #784

Merged
merged 18 commits into from
Apr 29, 2019
Merged

Update App Center copy #784

merged 18 commits into from
Apr 29, 2019

Conversation

john-light
Copy link
Contributor

@john-light john-light commented Apr 11, 2019 •
edited
Loading

  • Finance app manifest + details
  • Token Manager manifest + details
  • Vault manifest + details
  • Voting manifest + details

@john-light john-light requested review from dizzypaty and sohkai April 11, 2019 02:13
@john-light john-light marked this pull request as ready for review April 11, 2019 02:13
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.015% when pulling b7d2a02 on john-light-patch-1 into ad4a43c on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.015% when pulling b7d2a02 on john-light-patch-1 into ad4a43c on master.

@luisivan
Copy link
Contributor

luisivan commented Apr 17, 2019 •
edited
Loading

Won't get into 0.7, but will get into the immediate release after it, which should happen in a few days aragonone/product#56

@sohkai
Copy link
Contributor

sohkai commented Apr 26, 2019

@john-light This has been released on staging (e.g. https://aragon.staging.aragonpm.com/#/test.aragonid.eth/apps?p=installed.voting.aragonpm.eth).

@john-light
Copy link
Contributor Author

We might want to re-think the two-column layout:

Screenshot_2019-04-26 Aragon

@luisivan luisivan mentioned this pull request Apr 29, 2019
Closed
25 tasks
@bpierre
Copy link
Contributor

bpierre commented Apr 29, 2019

Apart from the content size issue, it shouldn’t break after titles, that’s weird 🤔 /cc @AquiGorka

@bpierre bpierre mentioned this pull request Apr 29, 2019
Merged
dizzypaty
dizzypaty approved these changes Apr 29, 2019
View reviewed changes
Copy link

@dizzypaty dizzypaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✍️ These descriptions are a great improvement!

@sohkai
Copy link
Contributor

sohkai commented Apr 29, 2019

@john-light We will move back to a one-column layout for the description in aragon/client#750.

@sohkai sohkai merged commit 1c32e8f into master Apr 29, 2019
@sohkai sohkai deleted the john-light-patch-1 branch April 29, 2019 14:47
MickdeGraaf pushed a commit to MickdeGraaf/aragon-apps that referenced this pull request Jan 28, 2020
@john-light @sohkai
Update App Center copy for core apps (aragon#784)
4c0754c
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
@john-light @sohkai
Update App Center copy for core apps (aragon#784)
77d2990
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizzypaty dizzypaty dizzypaty approved these changes

@sohkai sohkai sohkai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@john-light @coveralls @luisivan @sohkai @bpierre @dizzypaty