Agent, Finance: update date format #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Someone will review it soon 🔍 |
|
|
sohkai
approved these changes
Jun 22, 2020
There was a problem hiding this comment.
❤ thanks @FelixMohr!
One thing: could we also apply the same for the Agent app (since their codebases are pretty similar)?
|
Yes @sohkai, of course! I have made the changes. |
sohkai
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
❤️ Thanks @FelixMohr, this looks good to me now!
I've just added a few commits to clean up the unused formats and utilities :).
sohkai
changed the title
|
Congrats on merging your first pull request! Aragon is proud of you 🦅 |
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1173
This will update the date format in the UI components and also in the CSV export. Here are the screenshots:
