Fix CI #1172
Merged
Fix CI #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Vault, Agent and Finance. To fix Istanbul related issues. See https://github.com/aragon/aragonOS/releases/tag/v4.3.0 for more context.
added 2 commits
June 17, 2020 15:02
`isValidSignature` was calling the `bytes` version due to overloading issue with Truffle.
sohkai
approved these changes
Jun 17, 2020
|
|
||
|
|
||
| contract AgentMock is Agent { | ||
| function isValidSignatureBytes32(bytes32 _hash, bytes memory _signature) public view returns (bytes4) { |
There was a problem hiding this comment.
Could we leave a comment on why this is necessary?
sohkai
reviewed
Jun 17, 2020
| }) | ||
| }) | ||
|
|
||
| context('when there are two allowed token', function () { | ||
| it('expends ~49k gas in setting a allocation tokens per token', async () => { | ||
| const gas1 = 49 |
There was a problem hiding this comment.
Not a huge fan of these variable names (if we even need them at all)
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
* Upgrade aragonOS dependency For Vault, Agent and Finance. To fix Istanbul related issues. See https://github.com/aragon/aragonOS/releases/tag/v4.3.0 for more context. * payroll: fix gas values in tests * agent: fix tests `isValidSignature` was calling the `bytes` version due to overloading issue with Truffle. * Fix CI, address PR aragon#1172 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.