Finance: update verified token list and add Aave Tokens #1143
Conversation
Hello Aragon Team, I've added the Aave aTokens to this list, that what it's easier for AragonDAO users to interact with their DAO finance app with aTokens.
|
Thanks for opening this pull request! Someone will review it soon 🔍 |
|
|
|
Hmm, honestly not super sure what to do at this point as MyCrypto (upstream from us) seems to have removed their verified tokens list (see MyCryptoHQ/MyCrypto#3230). I've asked if they've opened sourced it, but otherwise, we may have to switch to a different resource for token addresses. Would it also make sense to upload these tokens to https://github.com/trustwallet/assets? I'll give it a few days, but otherwise in the short term I'll update the comments in the files on the current situation and that we'll maintain this list separately. |
| @@ -21,13 +21,16 @@ const MYCRYPTO_VERIFIED_TOKENS = [ | |||
| ['599GTO1', '0x5d9776472483ee2c2b204775547bff6db5a30fed'], | |||
There was a problem hiding this comment.
@marczeller Could you also copy this file into the Agent app's list: https://github.com/aragon/aragon-apps/blob/master/apps/agent/app/src/lib/verified-tokens.js?
There was a problem hiding this comment.
of course, PR done.
May I suggest Kleros Token TCR?, given both project history, they use Aragon for their governance, Aragon uses the TCR for curation, everybody wins.
but I guess this discussion is outside the immediate scope of this PR 😂
There was a problem hiding this comment.
Haha yes, I was thinking that too, but do you have the Aave tokens listed on the Token TCR? Anyhow, that was definitely a resolver we'd like to build into https://github.com/aragon/use-token for verification purposes.
There was a problem hiding this comment.
CLA signed, yeah, I've added all Aave related tokens there. use-token() seems cool!
There was a problem hiding this comment.
If you want to query the tokens of the T2CR, it's pretty easy, you can look at this example: https://codesandbox.io/s/t2cr-and-badges-nyqi6?file=/src/index.js
|
@marczeller It looks like MyCrypto pulls from If you haven't already, it would also be great to add the Aave tokens to that list—we will most likely periodically update this list from theirs! |
bpierre
changed the title
|
@marczeller Sorry it took so long to get back to this—I've updated this and #1144 lists now, and included better instructions for the future! |
sohkai
changed the title
|
Congrats on merging your first pull request! Aragon is proud of you 🦅 |
Hello Aragon Team,
I've added the Aave aTokens to this list, that what it's easier for AragonDAO users to interact with their DAO finance app with aTokens.