Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token Manager: creating new votes through a token manager can cause skewed votes #537

Open
sohkai opened this issue Oct 29, 2018 · 1 comment

Comments

@sohkai
Copy link
Contributor

sohkai commented Oct 29, 2018

If a Token Manager holds the governance token for a voting app, either because someone transferred tokens to it or it issued tokens to itself, and a vote is created by forwarding through the Token Manager, the Token Manager will automatically vote "yea" based on its current holdings.

Some potential ways to solve this:

  • Don't vote automatically when creating votes through a forward: the same UX as now would be possible, but could be difficult to implement generically, as aragon.js would need to provide a hook to get more information about the voting app and how to make direct transactions again it; also makes it impossible for another app to vote unless directly implemented, although some could argue that's a feature
  • Check if the msg.sender in the Voting app's forward() is a contract: can't be 100% sure, and has same second drawback as above
@sohkai
Copy link
Contributor Author

sohkai commented Apr 2, 2019

Another way to fix this is to remove the forwarding functionality from the Token Manager itself, and use a "Token balance" trigger instead as the forwarder.

@sohkai sohkai changed the title Creating new votes through a token manager that holds tokens causes skewed votes Creating new votes through a token manager can cause skewed votes Apr 4, 2019
@sohkai sohkai changed the title Creating new votes through a token manager can cause skewed votes Token Manager: creating new votes through a token manager can cause skewed votes Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant