You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If a Token Manager holds the governance token for a voting app, either because someone transferred tokens to it or it issued tokens to itself, and a vote is created by forwarding through the Token Manager, the Token Manager will automatically vote "yea" based on its current holdings.
Some potential ways to solve this:
Don't vote automatically when creating votes through a forward: the same UX as now would be possible, but could be difficult to implement generically, as aragon.js would need to provide a hook to get more information about the voting app and how to make direct transactions again it; also makes it impossible for another app to vote unless directly implemented, although some could argue that's a feature
Check if the msg.sender in the Voting app's forward() is a contract: can't be 100% sure, and has same second drawback as above
The text was updated successfully, but these errors were encountered:
Another way to fix this is to remove the forwarding functionality from the Token Manager itself, and use a "Token balance" trigger instead as the forwarder.
sohkai
changed the title
Creating new votes through a token manager that holds tokens causes skewed votes
Creating new votes through a token manager can cause skewed votes
Apr 4, 2019
sohkai
changed the title
Creating new votes through a token manager can cause skewed votes
Token Manager: creating new votes through a token manager can cause skewed votes
Mar 18, 2020
If a Token Manager holds the governance token for a voting app, either because someone transferred tokens to it or it issued tokens to itself, and a vote is created by forwarding through the Token Manager, the Token Manager will automatically vote "yea" based on its current holdings.
Some potential ways to solve this:
msg.sender
in the Voting app'sforward()
is a contract: can't be 100% sure, and has same second drawback as aboveThe text was updated successfully, but these errors were encountered: