Fixed spec for sort conditions. #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`arachne.aristotle.query.compiler/op` expects queries to generally have at most three arguments. For this to be true with `:top-n` and `:order` queries, the sort conditions need to be packed inside a list. With the old spec, the sort conditions were not nested, and thus `op` received the sort condition keyword as `a2` and the direction keyword as `amore`, with the query appended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arachne.aristotle.query.compiler/opexpects queries to generally have at most three arguments. Forthis to be true with
:top-nand:orderqueries, the sort conditions need to be packed inside alist.
With the old spec, the sort conditions were not nested, and thus
opreceived the sort conditionkeyword as
a2and the direction keyword asamore, with the query appended.