Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed spec for sort conditions. #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeeger
Copy link

@jeeger jeeger commented Jul 30, 2024

arachne.aristotle.query.compiler/op expects queries to generally have at most three arguments. For
this to be true with :top-n and :order queries, the sort conditions need to be packed inside a
list.

With the old spec, the sort conditions were not nested, and thus op received the sort condition
keyword as a2 and the direction keyword as amore, with the query appended.

`arachne.aristotle.query.compiler/op` expects queries to generally have at most three arguments. For
this to be true with `:top-n` and `:order` queries, the sort conditions need to be packed inside a
list.

With the old spec, the sort conditions were not nested, and thus `op` received the sort condition
keyword as `a2` and the direction keyword as `amore`, with the query appended.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant