Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test document for reference parsing #1

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

koppor
Copy link

@koppor koppor commented Oct 24, 2023

This PR adds a test PDF for JabRef#10437

image

Idea:

  1. Parse the attached PDF using the new feature
  2. Compare the parse result with the .bib file

The .bib file can be modified (e.g., authors shortened, ...). I just wanted to provide a complete example and see how it goes.

Note that the referenes are very complete and maybe need to be shortened drastically.

I just wanted to start with something.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor
Copy link
Author

koppor commented Oct 24, 2023

Update: I shortened the references to make them more "natural"

image

The references miss DOIs. In case parsing is much easier with DOIs, we can try to add them (maybe change some references in the example)

(More backround: https://tex.stackexchange.com/q/67444/9075)

@aqurilla aqurilla merged commit 0aa0d5f into aqurilla:fix-for-issue-10200 Oct 25, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants