Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add example of creating whitelist of checks #7821

Merged
merged 2 commits into from
Oct 31, 2024
Merged

docs: add example of creating whitelist of checks #7821

merged 2 commits into from
Oct 31, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Oct 30, 2024 •
edited
Loading

Description

There have been several questions from users about the ability to create a whitelist of checks. For example, #7814

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review October 30, 2024 07:23
@nikpivkin nikpivkin requested a review from knqyf263 as a code owner October 30, 2024 07:23
@nikpivkin nikpivkin requested a review from simar7 October 31, 2024 05:38
knqyf263
knqyf263 reviewed Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if putting this example here? It allows users to copy and reuse the example easily.
https://github.com/aquasecurity/trivy/tree/main/contrib/example_policy

@knqyf263
Copy link
Collaborator

Also, we should move the examples of the ignore policy to this directory.
https://github.com/aquasecurity/trivy/tree/main/examples

@nikpivkin
move example to file
3e72371 
Signed-off-by: nikpivkin <[email protected]>
@nikpivkin nikpivkin requested a review from knqyf263 October 31, 2024 07:57
@knqyf263 knqyf263 added this pull request to the merge queue Oct 31, 2024
Merged via the queue into aquasecurity:main with commit 7654b2e Oct 31, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

@simar7 simar7 Awaiting requested review from simar7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikpivkin @knqyf263