feat(misconf): Show misconfig ID in output

[simar7]

Description

Show misconfig ID in output

Before

my-file ()
==========
Tests: 1 (SUCCESSES: 0, FAILURES: 1, EXCEPTIONS: 0)
Failures: 1 (LOW: 0, MEDIUM: 0, HIGH: 1, CRITICAL: 0)

HIGH: Oh no, a bad config.
════════════════════════════════════════
Your config file is not good.

See https://google.com/search?q=bad%20config
────────────────────────────────────────
 my-file
────────────────────────────────────────
   1   
   2 [ bad: true
   3   
────────────────────────────────────────

After

my-file ()
==========
Tests: 1 (SUCCESSES: 0, FAILURES: 1, EXCEPTIONS: 0)
Failures: 1 (LOW: 0, MEDIUM: 0, HIGH: 1, CRITICAL: 0)

AVD-XYZ-0123 (HIGH): Oh no, a bad config.
════════════════════════════════════════
Your config file is not good.

See https://google.com/search?q=bad%20config
────────────────────────────────────────
 my-file
────────────────────────────────────────
   1   
   2 [ bad: true
   3   
────────────────────────────────────────

Related issues

• Close feat(misconf): Show misconfig ID in table (default) view #7629

Checklist

• I've read the guidelines for contributing to this repository.
• I've followed the conventions in the PR title.
• I've added tests that prove my fix is effective or that my feature works.
• I've updated the documentation with the relevant information (if needed).
• I've added usage information (if the PR introduces new options)
• I've included a "before" and "after" example to the description (if the PR is a user interface change).

[nikpivkin]

I think the before and after output should be added to the description.

[simar7]

I think the before and after output should be added to the description.

Thanks! I forgot about that.

[knqyf263]

I prefer a single line as below, but I guess @itaysk has some idea as it's his request.

AVD-XYZ-0123 (HIGH): Oh no, a bad config.

HIGH: Oh no, a bad config (AVD-XYZ-0123).

[itaysk]

agree with @knqyf263
of the two options I'd probably pick the first

[simar7]

I prefer a single line as below, but I guess @itaysk has some idea as it's his request.

AVD-XYZ-0123 (HIGH): Oh no, a bad config.

HIGH: Oh no, a bad config (AVD-XYZ-0123).

Agreed. Implemented 0513137

[knqyf263]

nit: There are some more options.

[AVD-XYZ-0123] HIGH: Oh no, a bad config.

AVD-XYZ-0123 [HIGH]: Oh no, a bad config.

<AVD-XYZ-0123> HIGH: Oh no, a bad config.

AVD-XYZ-0123 <HIGH>: Oh no, a bad config.

[knqyf263]

LGTM. If you prefer another option, please feel free to update and merge this PR.

[nikpivkin]

It is better to use the AVDID field instead of ID because ID can contain aliases https://github.com/aquasecurity/trivy/blob/main/pkg/misconf/scanner.go#L452-L454

s3-bucket-logging (LOW): Bucket has logging disabled
══════════════════════════════════════════════════════════════════════════════════════════════════════════════════
Ensures S3 bucket logging is enabled for S3 buckets

[simar7]

thanks! good catch, updated.