Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: apt-transport-https is a transitional package #7678

Merged

Conversation

simondeziel
Copy link
Contributor

This package contains nothing of value since at least Focal/20.04:

https://packages.ubuntu.com/focal/all/apt-transport-https/filelist:

/usr/share/doc/apt-transport-https/NEWS.Debian.gz
/usr/share/doc/apt-transport-https/changelog.gz
/usr/share/doc/apt-transport-https/copyright

@simondeziel simondeziel requested a review from knqyf263 as a code owner October 8, 2024 21:08
@CLAassistant
Copy link

CLAassistant commented Oct 8, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@simondeziel
Copy link
Contributor Author

Another suggestion while here: the doc says to download a public.key file that needs to be dearmor'ed wget -qO - https://aquasecurity.github.io/trivy-repo/deb/public.key | gpg --dearmor | ....

It'd be nice to avoid the dependency on gnupg by providing a .gpg file in the dearmor'ed format already that can be saved in the right directory without fiddling with it.

@simondeziel simondeziel changed the title docs/getting-started: apt-transport-https is a transitional package docs: apt-transport-https is a transitional package Oct 8, 2024
@simondeziel simondeziel force-pushed the apt-transport-https-transitional branch 2 times, most recently from 1899637 to bfa6843 Compare October 8, 2024 21:16
This package contains nothing of value since at least Focal/20.04:

https://packages.ubuntu.com/focal/all/apt-transport-https/filelist:
```
/usr/share/doc/apt-transport-https/NEWS.Debian.gz
/usr/share/doc/apt-transport-https/changelog.gz
/usr/share/doc/apt-transport-https/copyright
```

`apt`/`apt-get` doesn't need any extra to handle HTTPS URLs.

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel simondeziel force-pushed the apt-transport-https-transitional branch from bfa6843 to beaebd7 Compare October 10, 2024 18:11
@itaysk
Copy link
Contributor

itaysk commented Oct 13, 2024

providing a .gpg file in the dearmor'ed format already

make sense to me

@knqyf263 knqyf263 enabled auto-merge October 14, 2024 04:45
@knqyf263 knqyf263 added this pull request to the merge queue Oct 14, 2024
Merged via the queue into aquasecurity:main with commit 31aa20a Oct 14, 2024
7 checks passed
@simondeziel simondeziel deleted the apt-transport-https-transitional branch October 15, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants