Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misconf): fix for Azure Storage Account network acls adaptation #7602

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

nikpivkin
Copy link
Contributor

Description

  1. networkAcls is an object, not a list.
  2. bypass may contain multiple values separated by commas and may contain spaces. Spaces must be removed.

Doc: https://learn.microsoft.com/en-us/azure/templates/microsoft.storage/storageaccounts?pivots=deployment-language-arm-template

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review September 27, 2024 16:41
@nikpivkin nikpivkin requested a review from simar7 as a code owner September 27, 2024 16:41
@simar7
Copy link
Member

simar7 commented Oct 17, 2024

@nikpivkin looks like we need to rebase

@simar7 simar7 added this pull request to the merge queue Oct 18, 2024
Merged via the queue into aquasecurity:main with commit 35fd018 Oct 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants