Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify package addition and vulnerability scanning #6579

Merged
merged 4 commits into from
May 17, 2024

Conversation

knqyf263
Copy link
Collaborator

Description

This PR unifies package addition and vulnerability scanning into a single method to make it easier for projects importing Trivy to customise vulnerability scanning's behaviour.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 self-assigned this Apr 29, 2024
@knqyf263 knqyf263 force-pushed the refactor/package_vuln branch from a240334 to cbfb948 Compare April 30, 2024 17:50
@tonaim tonaim self-requested a review May 16, 2024 06:05
@knqyf263 knqyf263 marked this pull request as ready for review May 16, 2024 11:16
@knqyf263 knqyf263 requested a review from DmitriyLewen as a code owner May 16, 2024 11:16
@knqyf263
Copy link
Collaborator Author

@DmitriyLewen Can you please take a look?

Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 added this pull request to the merge queue May 17, 2024
Merged via the queue into aquasecurity:main with commit 4d4ea1d May 17, 2024
12 checks passed
@knqyf263 knqyf263 deleted the refactor/package_vuln branch May 17, 2024 08:00
knqyf263 added a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants