-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom docker socket for image scan option #2997
Comments
hey trivy team, please do review this request. Would like to work on it ! |
Hey trivy team. Is this feature request even valid ? Please validate it so that I can start working on a solution. |
Bumping this point, would like this option! additionally trivy should maybe always check for the colima socket, just like it does for podman etc.... |
Ahh ! Never mind about this issue ! It is easily possible in colima too if we are able to create a symbolic link between the colima socket file and the docker sock path. I ran Thanks for the support anyway. Please let me know if other container runtimes need to be supported. Would be happy to help ! |
Yes this works as well, however sadly i'm on a managed machine and this involves me getting the sudo permission first, which is rather cumbersome :) |
This issue is stale because it has been labeled with inactivity. |
I think |
In that case, I would like to work on it. Can you assign me to this issue ? |
Sure! @AndreyLevchenko will help. I think we want to add |
Hi, Can i load |
Hi @AndreyLevchenko , if this approach is fine, I can go ahead with the implementation. Wanted to follow up. What do you think ? |
1 similar comment
Sounds good |
Hi @knqyf263 can I get some ideas or pointers around how I should write tests for this feature ? |
Hi @aswath-s-tw |
Hey @knqyf263 @AndreyLevchenko please review the code/PR and suggest changes if any. Thanks ! |
…socket path works on windows (aquasecurity#2997)
…HostParam in windows test (aquasecurity#2997)
It would be great if we can have a flag for scanning local images with custom docker socket path.
I use colima as the container runtime for docker. The unix domain socket path for colima is
unix:///Users/<username>/.colima/default/docker.sock
while doing
trivy image <image_name>
, it throws an error sayingCannot connect to the Docker daemon at unix:///var/run/docker.sock
. Would be cool if it had an option similar totrivy image --socket <socket_path>
.The text was updated successfully, but these errors were encountered: