-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump up trivy to v0.57.1 #2301
Conversation
d7b3e21
to
709ae3c
Compare
033fb43
to
5fa71c0
Compare
@simar7 @nikpivkin there were some changes (renaming) in |
PR mentions an upgrade to v0.57.0, but v0.57.1 is already available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the pkg/
changes and they lgtm. @nikpivkin could you also take another look?
fixed |
@@ -690,7 +690,7 @@ policiesBundle: | |||
# -- repository of the policies bundle | |||
repository: aquasecurity/trivy-checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth changing the default value in the future after the release of trivy-checks in DockerHub in case the use of embedded checks is disabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Did you miss to bump the version of the chart or is there any reason? https://github.com/aquasecurity/trivy-operator/blob/main/deploy/helm/Chart.yaml#L9 I'm happy to provide a PR for the change. |
I've just seen that other changes have also been merged recently, and I assume it's not being updated because of the upcoming release? I apologize for my impatience and the inconvenience. |
It's OK |
Description
This PR updates dependencies related on Trivy 0.57.0 and fixes some vulnerabilities inside these ones.
Notes:
Support NVD CVSS V4.0 Schema was added in Trivy DB: feat(vulnsrc/nvd): add CVSS v4.0 trivy-db#414.
controller-runtime v0.19.0
contains a breaking change - a check for duplicate controller names (⚠️ Validate controller names are unique kubernetes-sigs/controller-runtime#2902). It's disabled for this PR and should be disabled for tests.More details: incorrect check for duplicate controller names kubernetes-sigs/controller-runtime#2937
Now using build-in Rego policies is disabled by default,
useEmbeddedRegoPolicies
is enabled. It allows to decrease downloads fromghcr.io
(the single source for trivy-checks)Trivy-operator uses
mirror.gcr.io
registry instead ofghcr.io
by default for some available OCI artifacts (trivy-db
,trivy-java-db
).Before:
After
Checklist