Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump up trivy to v0.57.1 #2301

Merged
merged 28 commits into from
Nov 19, 2024

Conversation

afdesk
Copy link
Contributor

@afdesk afdesk commented Oct 29, 2024

Description

This PR updates dependencies related on Trivy 0.57.0 and fixes some vulnerabilities inside these ones.

Notes:

Before:

trivy rootfs .
2024-10-29T17:43:58+06:00	INFO	[vuln] Vulnerability scanning is enabled
2024-10-29T17:43:58+06:00	INFO	[secret] Secret scanning is enabled
2024-10-29T17:43:58+06:00	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-29T17:43:58+06:00	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.56/docs/scanner/secret#recommendation for faster secret detection
2024-10-29T17:43:58+06:00	INFO	Number of language-specific files	num=1
2024-10-29T17:43:58+06:00	INFO	[gobinary] Detecting vulnerabilities...

to (gobinary)

Total: 3 (UNKNOWN: 0, LOW: 1, MEDIUM: 1, HIGH: 0, CRITICAL: 1)

┌──────────────────────────────────┬─────────────────────┬──────────┬────────┬──────────────────────┬─────────────────────────────────┬───────────────────────────────────────────────────────────┐
│             Library              │    Vulnerability    │ Severity │ Status │  Installed Version   │          Fixed Version          │                           Title                           │
├──────────────────────────────────┼─────────────────────┼──────────┼────────┼──────────────────────┼─────────────────────────────────┼───────────────────────────────────────────────────────────┤
│ github.com/docker/docker         │ CVE-2024-41110      │ CRITICAL │ fixed  │ v26.1.3+incompatible │ 23.0.15, 26.1.5, 27.1.1, 25.0.6 │ moby: Authz zero length regression                        │
│                                  │                     │          │        │                      │                                 │ https://avd.aquasec.com/nvd/cve-2024-41110                │
├──────────────────────────────────┼─────────────────────┼──────────┤        ├──────────────────────┼─────────────────────────────────┼───────────────────────────────────────────────────────────┤
│ github.com/open-policy-agent/opa │ CVE-2024-8260       │ MEDIUM   │        │ v0.65.0              │ 0.68.0                          │ opa: OPA SMB Force-Authentication                         │
│                                  │                     │          │        │                      │                                 │ https://avd.aquasec.com/nvd/cve-2024-8260                 │
├──────────────────────────────────┼─────────────────────┼──────────┤        ├──────────────────────┼─────────────────────────────────┼───────────────────────────────────────────────────────────┤
│ google.golang.org/grpc           │ GHSA-xr7q-jx4m-x55m │ LOW      │        │ v1.64.0              │ 1.64.1                          │ Private tokens could appear in logs if context containing │
│                                  │                     │          │        │                      │                                 │ gRPC metadata is...                                       │
│                                  │                     │          │        │                      │                                 │ https://github.com/advisories/GHSA-xr7q-jx4m-x55m         │
└──────────────────────────────────┴─────────────────────┴──────────┴────────┴──────────────────────┴─────────────────────────────────┴───────────────────────────────────────────────────────────┘

After

 trivy rootfs .                                           
2024-10-29T17:40:31+06:00	INFO	[vuln] Vulnerability scanning is enabled
2024-10-29T17:40:31+06:00	INFO	[secret] Secret scanning is enabled
2024-10-29T17:40:31+06:00	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-29T17:40:31+06:00	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.56/docs/scanner/secret#recommendation for faster secret detection
2024-10-29T17:40:31+06:00	INFO	Number of language-specific files	num=1
2024-10-29T17:40:31+06:00	INFO	[gobinary] Detecting vulnerabilities...

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@github-actions github-actions bot added the misc label Oct 29, 2024
@afdesk afdesk changed the title chore: bump up trivy to v0.56.2 chore: bump up trivy to v0.57.0 Nov 5, 2024
@afdesk afdesk marked this pull request as ready for review November 15, 2024 05:51
@afdesk
Copy link
Contributor Author

afdesk commented Nov 15, 2024

@simar7 @nikpivkin there were some changes (renaming) in iac/rego methods.
Could you check please that I update them correctly here? thanks!

@iamhalje
Copy link

iamhalje commented Nov 18, 2024

PR mentions an upgrade to v0.57.0, but v0.57.1 is already available

Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the pkg/ changes and they lgtm. @nikpivkin could you also take another look?

@afdesk afdesk changed the title chore: bump up trivy to v0.57.0 chore: bump up trivy to v0.57.1 Nov 19, 2024
@afdesk
Copy link
Contributor Author

afdesk commented Nov 19, 2024

PR mentions an upgrade to v0.57.0, but v0.57.1 is already available

fixed

@simar7 simar7 mentioned this pull request Nov 19, 2024
5 tasks
@@ -690,7 +690,7 @@ policiesBundle:
# -- repository of the policies bundle
repository: aquasecurity/trivy-checks

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth changing the default value in the future after the release of trivy-checks in DockerHub in case the use of embedded checks is disabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, sure.

Copy link

@nikpivkin nikpivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@afdesk afdesk merged commit 6f3499c into aquasecurity:main Nov 19, 2024
10 checks passed
@afdesk afdesk deleted the chore/bump-trivy-0.56.2 branch November 19, 2024 05:13
@hebestreit
Copy link

Did you miss to bump the version of the chart or is there any reason?

https://github.com/aquasecurity/trivy-operator/blob/main/deploy/helm/Chart.yaml#L9

I'm happy to provide a PR for the change.

@hebestreit
Copy link

I've just seen that other changes have also been merged recently, and I assume it's not being updated because of the upcoming release?

I apologize for my impatience and the inconvenience.

@afdesk
Copy link
Contributor Author

afdesk commented Nov 20, 2024

I've just seen that other changes have also been merged recently, and I assume it's not being updated because of the upcoming release?

I apologize for my impatience and the inconvenience.

It's OK
You're right, we want to cut a new release today/tomorrow, but we need to clarify some details.
sorry for inconvenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants