Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split image repositories into registry and repository #1137

Merged
merged 6 commits into from
Apr 14, 2023

Conversation

fhielpos
Copy link
Contributor

@fhielpos fhielpos commented Apr 3, 2023

Description

Related issues

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@chen-keinan
Copy link
Contributor

@fhielpos you'll have to run make generate-all from project folder and commit changes for verify code issue

@fhielpos
Copy link
Contributor Author

fhielpos commented Apr 5, 2023

Thanks @chen-keinan, had to also nest the Trivy server values since we already have a registry value there. Can you let the CI run again?

deploy/helm/README.md Outdated Show resolved Hide resolved
@chen-keinan
Copy link
Contributor

@fhielpos thank you for the contribution , I have added another comment

@fhielpos
Copy link
Contributor Author

Thanks for your comments @chen-keinan , all done 😄

@chen-keinan
Copy link
Contributor

lgtm , thank you for the contribution 🚀

@chen-keinan chen-keinan merged commit f441d1d into aquasecurity:main Apr 14, 2023
@fhielpos fhielpos deleted the feat-split-repository branch April 18, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting a custom registry in Helm deployment
2 participants