Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set to download DB daily #444

Merged
merged 1 commit into from
Oct 2, 2024
Merged

ci: set to download DB daily #444

merged 1 commit into from
Oct 2, 2024

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Oct 1, 2024

This PR changes to have clients download the DB once a day as we are facing GHCR rate limits. However, the DB will be built once every 6 hours.

@knqyf263 knqyf263 self-assigned this Oct 1, 2024
@knqyf263 knqyf263 requested a review from DmitriyLewen October 1, 2024 13:36
@knqyf263
Copy link
Collaborator Author

knqyf263 commented Oct 2, 2024

I'm testing this change in https://github.com/aquasecurity/trivy-db/actions/runs/11138880131.

@DmitriyLewen
Copy link
Contributor

I checked this locally:
it works correctly:

➜  cat metadata.json 
{"Version":2,"NextUpdate":"2024-10-03T04:43:04.211896Z","UpdatedAt":"2024-10-02T04:43:04.211897Z","DownloadedAt":"0001-01-01T00:00:00Z"}

@knqyf263
Copy link
Collaborator Author

knqyf263 commented Oct 2, 2024

Great. Since this change impacts all users, I'd like to re-test it on GitHub Actions just in case.

@knqyf263
Copy link
Collaborator Author

knqyf263 commented Oct 2, 2024

I locally confirmed the new DB worked with Trivy.

@knqyf263 knqyf263 merged commit 32c63a9 into main Oct 2, 2024
4 checks passed
@knqyf263 knqyf263 deleted the change_interval branch October 2, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants