-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add examples of custom checks #295
Conversation
9d804f4
to
76bda8b
Compare
Signed-off-by: Nikita Pivkin <[email protected]>
Signed-off-by: Nikita Pivkin <[email protected]>
@simar7 In this PR trivy runs as a cli application via a package, which locks us into the version of trivy specified in go.mod. Alternatively, we can run the latest version of trivy via localstack, which will allow us to run tests in parallel and reduce the number of transitive dependencies (but I don't think this is critical). But then we would have to consider whether it would be too expensive to run such tests often. And the third option is to just install trivy via |
Interesting, why are they expensive to run in localstack? I think running them in localstack is actually good as it adds a layer of integration testing for us in trivy-checks to ensure nothing breaks in Trivy when we release a new trivy-checks version. Also we could add other verisons of Trivy here (besides latest) to ensure we test against a set of versions. |
We will pull the Trivy image every time we run the tests . Or can we cache it? If the cache will not be invalidated, we will constantly pull the same version of Trivy in case of using latest tag. |
Let's merge this in for now as it's better than nothing and improve it in further iterations. I think for this PR this work is sufficient for now. |
Related issues:
This PR includes:
--config-data
flagsh.parse_commands
to parse shell scripts