-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Produce a manifest with a non-zero config #270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbandy
force-pushed
the
compatible-config
branch
from
October 9, 2024 16:21
bd5b035
to
aaeab29
Compare
simar7
force-pushed
the
compatible-config
branch
from
October 10, 2024 04:51
aaeab29
to
333d125
Compare
@cbandy thanks for the catch, it lgtm! |
simar7
previously approved these changes
Oct 10, 2024
One small note, we can also add this to our testing here: trivy-checks/scripts/verify-bundle.go Line 17 in e0baac7
|
cbandy
force-pushed
the
compatible-config
branch
from
October 10, 2024 14:41
333d125
to
a2f1501
Compare
Some OCI registry implementations do not know how to handle completely empty manifest config. ORAS knows what to do in this case. See: https://github.com/opencontainers/image-spec/blob/v1.1.0/manifest.md#guidance-for-an-empty-descriptor
cbandy
force-pushed
the
compatible-config
branch
from
October 10, 2024 14:41
a2f1501
to
7b5526c
Compare
Thank you for the quick response! Amended and rebased. 📝 I was not able to run that test locally. |
For reference, here's the issue I opened with Harbor: goharbor/harbor#21018 |
simar7
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not copy
trivy-checks
into Harbor today because Harbor does not understand a"size":0
manifest config.The OCI image spec calls out this case and recommends sending an empty JSON object instead: https://github.com/opencontainers/image-spec/blob/v1.1.0/manifest.md#guidance-for-an-empty-descriptor
ORAS knows what to do with these things, so this change uses it the same way as
trivy-db
: https://github.com/aquasecurity/trivy-db/blob/32c63a9af03ffd449a6ffb4471745b6ec9714875/.github/workflows/cron.yml#L73Here's a discussion about the OPA bundle format showing similar: open-policy-agent/opa#1413 (comment)