fix(checks): correctly check the addresses count in the AVD-NIF-0001 rule #267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nifcloud computing rules were migrated to Rego at #185, but I found a difference with original Go rule.
Go: https://github.com/aquasecurity/trivy-checks/blob/v1.1.0/checks/cloud/nifcloud/computing/no_public_ingress_sgr.go#L40
Rego: https://github.com/aquasecurity/trivy-checks/blob/v1.1.0/checks/cloud/nifcloud/computing/no_public_ingress_sgr.rego#L39
In Golang, it was an error if the address count was more than 1 (
> 1
), But in Rego, it is an error if the count is greater than 0 (> 0
).I think it is correct to follow the Go code and use
> 1
as the condition.