Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: initialise tests in each test file #234

Merged
merged 1 commit into from
Aug 22, 2024
Merged

test: initialise tests in each test file #234

merged 1 commit into from
Aug 22, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Aug 22, 2024 •
edited
Loading

Will avoid merge conflicts

@nikpivkin nikpivkin requested a review from simar7 as a code owner August 22, 2024 10:34
simar7
simar7 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's fine but it's much easier if we have them back in the map as if we ever need to run a subset of tests, for instance for debugging, it's easier to comment them out.

@simar7 simar7 added this pull request to the merge queue Aug 22, 2024
Merged via the queue into aquasecurity:main with commit 78a74ef Aug 22, 2024
5 checks passed
@nikpivkin nikpivkin deleted the test-init branch August 23, 2024 03:08
@nikpivkin
Copy link
Contributor Author

I'll bring it back later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikpivkin @simar7