Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump setup-trivy to v0.2.1 #411

Merged

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Oct 11, 2024

Description

Bump setup-trivy to v0.2.1.
v0.2.1 now uses git + install script - to avoid using unverified actions.

Test run - https://github.com/DmitriyLewen/test-trivy-action/actions/runs/11323935676/job/31487644774

action.yaml Outdated Show resolved Hide resolved
@DmitriyLewen DmitriyLewen marked this pull request as ready for review October 14, 2024 08:40
Copy link

@Roy-Gal-Git Roy-Gal-Git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 requested a review from simar7 October 14, 2024 08:45
Copy link
Contributor

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd defer to @simar7

@simar7 simar7 self-requested a review October 14, 2024 17:57
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DmitriyLewen backticks here will be evaluated by the shell https://github.com/aquasecurity/setup-trivy/blob/main/action.yaml#L32C9-L32C84

echo "'setup-trivy' doesn't currently support caching the `latest` version"
zsh: command not found: latest
'setup-trivy' doesn't currently support caching the  version

PR to fix: aquasecurity/setup-trivy#8

@DmitriyLewen
Copy link
Contributor Author

Strange, I already fixed it...
Most likely trying to fix the cache for windows runners I accidentally used backticks again.

Thanks, merged!

@Roy-Gal-Git
Copy link

@DmitriyLewen DmitriyLewen changed the title chore(deps): bump setup-trivy to v0.2.0 chore(deps): bump setup-trivy to v0.2.1 Oct 15, 2024
@DmitriyLewen
Copy link
Contributor Author

@Roy-Gal-Git bumped to v0.2.1

@simar7 simar7 merged commit 915b19b into aquasecurity:master Oct 15, 2024
2 checks passed
@DmitriyLewen DmitriyLewen deleted the chore/bump-setup-trivy-v0.2.0 branch October 16, 2024 06:57
@palloberg
Copy link

@simar7 Is there a chance to have trivy-action v0.29.0 released as it seems to resolve issues with using the action in a GitHub Enterprise Server setup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants