Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use setup-trivy to install Trivy #406

Merged
merged 1 commit into from
Oct 9, 2024
Merged

ci: use setup-trivy to install Trivy #406

merged 1 commit into from
Oct 9, 2024

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Oct 9, 2024 •
edited
Loading

Description

For some runners there is a problem with curl and sudo when installing Trivy.
See #403 for details

So we need to use setup-trivy to install Trivy.

Test runs:

Related issues

@DmitriyLewen DmitriyLewen marked this pull request as ready for review October 9, 2024 10:15
knqyf263
knqyf263 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I'd defer to @simar7.

@simar7
Copy link
Member

simar7 commented Oct 9, 2024

LGTM, I just made a small improvement to the setup-trivy action aquasecurity/setup-trivy#3

@simar7 simar7 merged commit 0fa0cdb into aquasecurity:master Oct 9, 2024
1 of 2 checks passed
@DmitriyLewen DmitriyLewen deleted the fix/use-setup-trivy branch October 10, 2024 04:16
@DmitriyLewen DmitriyLewen mentioned this pull request Oct 10, 2024
Closed
@cafesanu cafesanu mentioned this pull request Oct 10, 2024
Open
@Kieffer87 Kieffer87 mentioned this pull request Oct 15, 2024
Merged
@smola smola mentioned this pull request Oct 23, 2024
Open
@darliiin darliiin mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trivy-action attempts to run sudo on the local machine (!?)
3 participants
@DmitriyLewen @simar7 @knqyf263