Feature/tasks hashes types #3505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rafaeldtinoco if something with the protobuf is not correct you are welcome to just change it and push again. |
Add thread and parent process entity ids to the event structure. Renamed current entity id so its use will be clear.
As it is now available, add the thread entity id to the protobuf.
AlonZivony
force-pushed
the
feature/tasks-hashes-types
branch
from
5f95c5d to
29bf9d0
Compare
|
@josedonizetti mind taking a quick look ? I'll run the protobuf compiler on this change as well. or Alon, you missed: git commit -a -m 'feature(types): compile protobuf changes for entity ids' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types change for #3503