Add support for CIS OpenShift 1.6 Benchmark #1682
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
deebhatia
commented
Sep 18, 2024
| @@ -13,7 +13,7 @@ groups: | |||
| type: "manual" | |||
| audit: | | |||
| #To get a list of users and service accounts with the cluster-admin role | |||
| oc get clusterrolebindings -o=customcolumns=NAME:.metadata.name,ROLE:.roleRef.name,SUBJECT:.subjects[*].kind | | |||
| oc get clusterrolebindings -o=custom-columns=NAME:.metadata.name,ROLE:.roleRef.name,SUBJECT:.subjects[*].kind | | |||
There was a problem hiding this comment.
This was a typo in the benchmark. I was comparing both the standards when I identified this. The type is marked as manual, so wasn't caught earlier.
anchal39
approved these changes
Sep 27, 2024
deebhatia
force-pushed
the
cis-openshift-1-6
branch
3 times, most recently
from
2873eea
to
d2041f5
Compare
|
Hi @afdesk @mozillazg, |
|
Hi @deebhatia! |
safiyat
force-pushed
the
cis-openshift-1-6
branch
from
ac899d1
to
c8d2de5
Compare
|
Hi @afdesk, Can you please take some time out and review it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support of CIS OpenShift 1.6 Benchmark.
Closes #1457
CIS Benchmark Link
https://workbench.cisecurity.org/benchmarks/16094
CIS Blog mentioning the OpenShift 4.15 release version
https://www.cisecurity.org/insights/blog/cis-benchmarks-july-2024-update#CISRedHatOpenShiftContainerPlatformBenchmarkv1.6.0
Sample Run
Command Used
kube-bench run --json --version ocp-4.16
Report
1_6_results.json