-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with get repo info #130 #132
Conversation
Changed BaseURL in test from gitlab to github.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the test, was the wrong BaseURL set for "github project under sub org with same name as repo"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests seem good, but target Github, and subgroups do not apply there. I added code suggestions to replace it to Gitlab, let me know if this is what you meant
Co-authored-by: Mor Weinberger <[email protected]>
Co-authored-by: Mor Weinberger <[email protected]>
Co-authored-by: Mor Weinberger <[email protected]>
LGTM, accepted the changes, added for github as well since It was the same problem their if a org had the same name as repo. |
Hi, I don't see the tested you added for github |
You are right, your changes did override them. Do you want me to add them again or should we ignore them? |
Description
Issue when the sub group has the same name as the repository.
The getRepoInfo function does not parse it out correctly.
This fixes this issue.
Example url:
https://my-gitlab-instance.com/top-group/sub-group/repo-name/repo-name
getRepoInfo returned before:
it now returns:
Related issues
Might close:
Checklist