Support aqua rm for go_install packages without --all

[sapphi-red]

Feature Overview

aqua rm doesn't support go_install packages unless --all is passed.
https://aquaproj.github.io/docs/guides/uninstall-packages/#limitation

It would be nice if aqua rm supports removing go_install packages without requiring --all.

Why is the feature needed?

When I try some packages that is go_install type and decided not to use it, I want to remove the binaries to save storage space.

Workaround

• manually finding the binary and removing it
  • aqua rm is easier
• run aqua rm --all
  • I'll have to install packages again

Example Code

No response

Note

refs https://github.com/orgs/aquaproj/discussions/2903
refs #538

[suzuki-shunsuke]

📝

aqua/pkg/controller/remove/remove.go

Lines 157 to 162 in 4ba02d7

	func (c *Controller) removePackage(logE *logrus.Entry, rootDir string, pkg *registry.PackageInfo) error {
	path := pkg.PkgPath()
	if path == "" {
	logE.WithField("package_type", pkg.Type).Warn("this package type can't be removed")
	return nil
	}

aqua/pkg/config/registry/package_info.go

Lines 636 to 646 in 4ba02d7

	func (p *PackageInfo) PkgPath() string {
	switch p.Type {
	case PkgInfoTypeGitHubArchive, PkgInfoTypeGoBuild, PkgInfoTypeGitHubContent, PkgInfoTypeGitHubRelease:
	return filepath.Join(p.Type, "github.com", p.RepoOwner, p.RepoName)
	case PkgInfoTypeCargo:
	return filepath.Join(p.Type, "crates.io", p.Crate)
	case PkgInfoTypeGoInstall, PkgInfoTypeHTTP:
	return ""
	}
	return ""
	}

aqua/pkg/config/package.go

Lines 91 to 96 in 4ba02d7

	case PkgInfoTypeGoInstall:
	p, err := p.RenderPath()
	if err != nil {
	return "", fmt.Errorf("render Go Module Path: %w", err)
	}
	return filepath.Join(rootDir, "pkgs", pkgInfo.Type, p, pkg.Version, "bin"), nil

[suzuki-shunsuke]

I remembered why we didn't support this feature.

go_install's path can depend on a version.

e.g.

https://aquaproj.github.io/docs/reference/registry-config/go-install-package

path: github.com/volatiletech/sqlboiler/v{{(semver .Version).Major}}

To uninstall a package, aqua must be able to detect a file path to be removed independent of version.

In the above example, it's github.com/volatiletech/sqlboiler but it's difficult to detect the path programatically.

To resolve this issue, my idea is to add a field to detect a file path to be removed.

# TODO: decide the field name
# package_dir, base_dir
removed_dir: github.com/volatiletech/sqlboiler

Using this field, we can uninstall not only go_install type packages but also http type packages.

[suzuki-shunsuke]

• feat: enable you to remove go_install and http packages #3101

[suzuki-shunsuke]

v2.33.0 is out 🎉
https://github.com/aquaproj/aqua/releases/tag/v2.33.0

This release supports not only go_install but also http packages.
Furthermore, we could resolve this issue without adding a new field.

#2905 (comment)

To resolve this issue, my idea is to add a field to detect a file path to be removed.