Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MemRef should be able to point to a MemBlock with a negative offset. #84

Open
makesource opened this issue Aug 10, 2021 · 2 comments
Open

MemRef should be able to point to a MemBlock with a negative offset. #84

makesource opened this issue Aug 10, 2021 · 2 comments

Comments

@makesource
Copy link
Collaborator

No description provided.

@aqjune
Copy link
Owner

aqjune commented Aug 22, 2021

A related issue: from1DIdx and to1DIdx are using urem/udiv, but this seems fishy

aqjune added a commit that referenced this issue Dec 6, 2021
@aqjune
Remove Expr::mod
08c22a7 
- Expr::mod's simplification was buggy
- It isn't clear why index % size must use Expr::mod, not Expr::urem; can index be negative? (#84 does not describe its reason)
@aqjune
Copy link
Owner

aqjune commented Dec 6, 2021

Related: LLVM's pointer can have a negative offset from the address of an allocation But it is not clear whether this should be supported in MemRef.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aqjune @makesource