Add createCollection API to the SDK #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heliuchuan
requested review from
0xmaayan,
gregnazario,
0xmigo and
a team
as code owners
0xmaayan
previously requested changes
Oct 18, 2023
Yes, let's combine |
gregnazario
force-pushed
the
add-create-collection
branch
from
bdf527c to
88d8c60
Compare
|
@heliuchuan just for reference, I addressed the merge conflicts, we can get these two PRs in, and then combine them into one digitalAssets, which should just be an easy rename. |
gregnazario
approved these changes
Oct 18, 2023
gregnazario
reviewed
Oct 18, 2023
Comment on lines
+57
to
+61
| } & CreateCollectionOptions, | ||
| ): Promise<SingleSignerTransaction> { | ||
| return createCollectionTransaction({ aptosConfig: this.config, ...args }); | ||
| } | ||
|
|
There was a problem hiding this comment.
Returning a SingleSigner may be weird if we also support Fee payer, but I'm not sure how that model is going to look cc @0xmaayan
gregnazario
force-pushed
the
add-create-collection
branch
from
88d8c60 to
ff50886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a function for users to invoke 0x4::aptos_token::create_collection via the SDK
Test Plan
pnpm test
Related Links